fix #8761 #8767
Merged
fix #8761 #8767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uecasm
reviewed
Nov 13, 2022
| { | ||
| recalculated = true; |
There was a problem hiding this comment.
Shouldn't it also set this to false when it completes the job or something?
There was a problem hiding this comment.
No, this is specifically if the builder is unloaded mid build. They have a request open and then don't recalc the list, if the builder is unloaded again, the variable auto resets to false
someaddons
reviewed
Nov 13, 2022
src/main/java/com/minecolonies/coremod/entity/citizen/VisitorCitizen.java
Show resolved
Hide resolved
someaddons
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8761
Closes #8766
Closes #8763
Changes proposed in this pull request:
Review please