Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/perf #8801

Merged
merged 9 commits into from
Dec 4, 2022
Merged

Feature/perf #8801

merged 9 commits into from
Dec 4, 2022

Conversation

Raycoms
Copy link
Contributor

@Raycoms Raycoms commented Dec 3, 2022

Closes #
Closes #
Closes #

Changes proposed in this pull request:

  • Fix insane paper request rate
  • Remove unnecessary vanilla calls
  • Reduce some tickrates
  • Some additional caching

Review please

@@ -371,10 +371,7 @@ protected Colony(final int id, @Nullable final Level world)
colonyStateMachine.addTransition(new TickingTransition<>(INACTIVE, () -> true, this::updateState, UPDATE_STATE_INTERVAL));
colonyStateMachine.addTransition(new TickingTransition<>(UNLOADED, () -> true, this::updateState, UPDATE_STATE_INTERVAL));
colonyStateMachine.addTransition(new TickingTransition<>(ACTIVE, () -> true, this::updateState, UPDATE_STATE_INTERVAL));
colonyStateMachine.addTransition(new TickingTransition<>(ACTIVE, () -> true, () -> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@someaddons any reason this wasnt a normal one before?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a normal one xD just a lamda since it was a void

Mekle001
Mekle001 previously approved these changes Dec 3, 2022
@Raycoms Raycoms merged commit 6aec46b into version/1.19 Dec 4, 2022
@Raycoms Raycoms deleted the feature/perf branch December 4, 2022 18:32
Raycoms added a commit that referenced this pull request Dec 29, 2022
Fix insane paper request rate
Remove unnecessary vanilla calls
Reduce some tickrates
Some additional caching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants