Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/8877 #8878

Merged
merged 3 commits into from
Jan 8, 2023
Merged

Fix/8877 #8878

merged 3 commits into from
Jan 8, 2023

Conversation

Thodor12
Copy link
Contributor

@Thodor12 Thodor12 commented Jan 8, 2023

Closes #8877

Changes proposed in this pull request:

  • Town hall window no longer shows colony name + level
  • Logic was changed up a little bit so that the abstract window is not responsible for selecting how to pick the town hall name

There is no way of seeing the town hall level as of right now though, as that level was the only indicator, do we want to place this elsewhere?

@Raycoms
Copy link
Contributor

Raycoms commented Jan 8, 2023

Good question, can't think of a good place atm

@Raycoms Raycoms merged commit 2fbbcc5 into ldtteam:version/main Jan 8, 2023
@Thodor12 Thodor12 deleted the fix/8877 branch January 8, 2023 20:26
Thodor12 added a commit to Thodor12/minecolonies that referenced this pull request Jan 8, 2023
@Thodor12 Thodor12 mentioned this pull request Jan 8, 2023
Thodor12 added a commit to Thodor12/minecolonies that referenced this pull request Jan 8, 2023
@Thodor12 Thodor12 mentioned this pull request Jan 8, 2023
Raycoms pushed a commit that referenced this pull request Jan 8, 2023
Raycoms pushed a commit that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Colony naming Issue in townhall
3 participants