Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change surnames and firstnames to Chinese characters (1.20.1) #9564

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Change surnames and firstnames to Chinese characters (1.20.1) #9564

merged 5 commits into from
Dec 22, 2023

Conversation

mc-kaishixiaxue
Copy link
Contributor

Test screenshot
2023-11-12_20 15 36

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Raycoms
Copy link
Contributor

Raycoms commented Dec 20, 2023

@mc-kaishixiaxue can you adjust the PR to add it as a second chinese set instead of replacing it?

@Raycoms Raycoms merged commit cb0ed41 into ldtteam:version/main Dec 22, 2023
2 checks passed
Raycoms pushed a commit that referenced this pull request Dec 22, 2023
@mc-kaishixiaxue @Raycoms
Change surnames and firstnames to Chinese characters (1.20.1) (#9564)
b3b027d 
Add chinese character style nameset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raycoms Raycoms Raycoms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mc-kaishixiaxue @CLAassistant @Raycoms