Avoid nearby colony lookup on each frame #9972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raycoms
approved these changes
Jun 2, 2024
|
Wouldn't it make more sense to cache this based on the player crossing chunk boundaries? There's already some other stuff in here that does that, and the nearby colony is unlikely to change without the player moving around. |
|
The other stuff you're thinking on is serverside, clientside just has one player and data is more volatile due to sync timing. So performance wise there is little benefit to more caching and it'd have a higher risk of problems |
|
Just wonderin, can't we do once per second vs random out of 20? |
|
No, it's client-side too. Look inside the |
Raycoms
added a commit
that referenced
this pull request
Jul 27, 2024
Avoid nearby colony lookup on each frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Closes #
Changes proposed in this pull request:
[x ] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.
Review please