Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Proof of Hermite theorem on number fields of bounded discriminant #10030

Closed
wants to merge 13 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Jan 26, 2024

Let N be an integer. Then there are only finitely many number fields (in some fixed extension of ) of discriminant bounded in absolute value by N.


Open in Gitpod

@xroblot xroblot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Jan 26, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib label Jan 26, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 7, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Feb 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 19, 2024
@riccardobrasca riccardobrasca self-assigned this Feb 19, 2024
@riccardobrasca riccardobrasca added the t-algebra Algebra (groups, rings, fields etc) label Feb 23, 2024
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/NumberTheory/NumberField/CanonicalEmbedding.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 23, 2024

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@xroblot
Copy link
Collaborator Author

xroblot commented Feb 23, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 23, 2024
…nt (#10030)

Let `N` be an integer.  Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Proof of Hermite theorem on number fields of bounded discriminant [Merged by Bors] - feat: Proof of Hermite theorem on number fields of bounded discriminant Feb 23, 2024
@mathlib-bors mathlib-bors bot closed this Feb 23, 2024
@mathlib-bors mathlib-bors bot deleted the xfr-hermite branch February 23, 2024 12:16
thorimur pushed a commit that referenced this pull request Feb 24, 2024
…nt (#10030)

Let `N` be an integer.  Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
thorimur pushed a commit that referenced this pull request Feb 26, 2024
…nt (#10030)

Let `N` be an integer.  Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
…nt (#10030)

Let `N` be an integer.  Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
…nt (#10030)

Let `N` be an integer.  Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…nt (#10030)

Let `N` be an integer.  Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields etc) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants