-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Proof of Hermite theorem on number fields of bounded discriminant #10030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobrasca
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors d+
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
…nt (#10030) Let `N` be an integer. Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
Pull request successfully merged into master. Build succeeded: |
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
…nt (#10030) Let `N` be an integer. Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
…nt (#10030) Let `N` be an integer. Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
…nt (#10030) Let `N` be an integer. Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…nt (#10030) Let `N` be an integer. Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
…nt (#10030) Let `N` be an integer. Then there are only finitely many number fields (in some fixed extension of `ℚ`) of discriminant bounded in absolute value by `N`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
t-algebra
Algebra (groups, rings, fields etc)
t-number-theory
Number theory (also use t-algebra or t-analysis to specialize)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let
N
be an integer. Then there are only finitely many number fields (in some fixed extension ofℚ
) of discriminant bounded in absolute value byN
.IntermediateField.lift
is injective #10031CanonicalEmbedding
should beNNReal
and notENNReal
#10032NumberField.is_primitive_element_of_infinitePlace_lt
#10033