[Merged by Bors] - chore(LinearAlgebra/QuadraticForm): fixups to #10097 #10167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parcly-Taxel
reviewed
Feb 1, 2024
Parcly-Taxel
approved these changes
Feb 1, 2024
mans0954
approved these changes
Feb 2, 2024
jcommelin
approved these changes
Feb 3, 2024
Comment on lines
28
to
34
| (R : Type*) {A M N P : Type*} | ||
| [CommSemiring R] [CommSemiring A] | ||
| [AddCommMonoid M] [AddCommMonoid N] [AddCommMonoid P] | ||
| [Algebra R A] | ||
| [Module R M] [Module R N] [Module R P] | ||
| [Module A M] [Module A N] [Module A P] | ||
| [IsScalarTower R A M] [IsScalarTower R A N] [IsScalarTower R A P] |
There was a problem hiding this comment.
Could this share some variables with the rest of the file?
There was a problem hiding this comment.
I found doing so rather difficult, there are too many typeclasses I don't want earlier in the file, and confusion over linear vs semilinear maps.
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
|
Build failed (retrying...): |
|
Build failed:
|
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't get a chance to review #10097 before it was merged; this contains some minor fixups.
This removes
LinearMap.linMulLin, as it can be recovered easily viaLinearMap.mul.