Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' #10896

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' #10896

wants to merge 1 commit into from

Conversation

acmepjz
Copy link
Collaborator

@acmepjz acmepjz commented Feb 23, 2024

Open in Gitpod

@acmepjz acmepjz added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Feb 23, 2024
@acmepjz acmepjz mentioned this pull request Feb 23, 2024
Closed
3 tasks
riccardobrasca
riccardobrasca approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 23, 2024

✌️ acmepjz can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@acmepjz
Copy link
Collaborator Author

acmepjz commented Feb 23, 2024

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 23, 2024

👎 Rejected by label

@riccardobrasca
Copy link
Member

Let's just wait for the build to finish.

@acmepjz
Copy link
Collaborator Author

acmepjz commented Feb 23, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 23, 2024
@acmepjz
feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' (#10896
c951d81 
)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' [Merged by Bors] - feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' Feb 23, 2024
@mathlib-bors mathlib-bors bot closed this Feb 23, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_i_f_rank_bot branch February 23, 2024 23:30
thorimur pushed a commit that referenced this pull request Feb 24, 2024
@acmepjz @thorimur
feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' (#10896
e153ec0 
)
thorimur pushed a commit that referenced this pull request Feb 26, 2024
@acmepjz @thorimur
feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' (#10896
45a5d03 
)
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
@acmepjz @riccardobrasca
feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' (#10896
a194338 
)
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@acmepjz @dagurtomas
feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' (#10896
d02b646 
)
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@acmepjz @Louddy
feat(FieldTheory/Adjoin): add IntermediateField.[fin]rank_bot' (#10896
49df889 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobrasca riccardobrasca riccardobrasca approved these changes

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acmepjz @riccardobrasca @leanprover-community-mathlib4-bot