Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Util/SynthesizeUsing): Qq-ify #9437

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 4, 2024

Most of the callers were already passing q() arguments anyway.


Open in Gitpod

As requested by @dwrensha in #9421

@eric-wieser eric-wieser added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. t-meta Tactics, attributes or user commands awaiting-CI labels Jan 4, 2024
@eric-wieser eric-wieser changed the title chore(Util/SynthesizeUsing): QQ-ify chore(Util/SynthesizeUsing): Qq-ify Jan 4, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 11, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 10, 2024
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 12, 2024
Most of the callers were already passing `q()` arguments anyway.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Util/SynthesizeUsing): Qq-ify [Merged by Bors] - chore(Util/SynthesizeUsing): Qq-ify Feb 12, 2024
@mathlib-bors mathlib-bors bot closed this Feb 12, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/Qq-ify-synthesizeUsing branch February 12, 2024 11:39
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Most of the callers were already passing `q()` arguments anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants