[Merged by Bors] - feat: change Subgroup and Submonoid induction principles to work with induction
#9861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fact I only need the `closure` lemma, but the others are easy enough.
…with `induction`
eric-wieser
added
t-algebra
eric-wieser
changed the title
Subgroup and Submonoid induction principles to work with induction
leanprover-community-mathlib4-bot
added
blocked-by-other-PR
|
This PR/issue depends on: |
leanprover-community-mathlib4-bot
added
the
merge-conflict
…-induction-dependent
eric-wieser
removed
the
merge-conflict
adomani
approved these changes
Feb 8, 2024
|
LGTM, module @_adomani's comment. bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
…with `induction` (#9861) Induction principles have to be fully dependent in order to work with the `induction` tactic. This is usually a good thing anyway, since the dependent version is often more convenient to use, and avoids the caller having to fumble with generalizing over an existential. This changes the following induction principles (and their additive versions): * `Submonoid.closure_induction_{left,right}` * `Subgroup.closure_induction_{left,right}` * `Subgroup.closure_induction''` (no submonoid version exists) Arguments to these lemmas have also been renamed to drop the `H`, as seems to be preferred for `induction` lemmas.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Subgroup and Submonoid induction principles to work with inductionSubgroup and Submonoid induction principles to work with induction
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
…with `induction` (#9861) Induction principles have to be fully dependent in order to work with the `induction` tactic. This is usually a good thing anyway, since the dependent version is often more convenient to use, and avoids the caller having to fumble with generalizing over an existential. This changes the following induction principles (and their additive versions): * `Submonoid.closure_induction_{left,right}` * `Subgroup.closure_induction_{left,right}` * `Subgroup.closure_induction''` (no submonoid version exists) Arguments to these lemmas have also been renamed to drop the `H`, as seems to be preferred for `induction` lemmas.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…with `induction` (#9861) Induction principles have to be fully dependent in order to work with the `induction` tactic. This is usually a good thing anyway, since the dependent version is often more convenient to use, and avoids the caller having to fumble with generalizing over an existential. This changes the following induction principles (and their additive versions): * `Submonoid.closure_induction_{left,right}` * `Subgroup.closure_induction_{left,right}` * `Subgroup.closure_induction''` (no submonoid version exists) Arguments to these lemmas have also been renamed to drop the `H`, as seems to be preferred for `induction` lemmas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Induction principles have to be fully dependent in order to work with the
inductiontactic. This is usually a good thing anyway, since the dependent version is often more convenient to use, and avoids the caller having to fumble with generalizing over an existential.This changes the following induction principles (and their additive versions):
Submonoid.closure_induction_{left,right}Subgroup.closure_induction_{left,right}Subgroup.closure_induction''(no submonoid version exists)Arguments to these lemmas have also been renamed to drop the
H, as seems to be preferred forinductionlemmas.Sub{group,monoid}.{op,unop}#9860