Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Added NPM package.json. #4

Merged
merged 1 commit into from
Jun 4, 2016
Merged

Added NPM package.json. #4

merged 1 commit into from
Jun 4, 2016

Conversation

leighmcculloch
Copy link
Owner

Added NPM package.json.

As requested by @mef in robflaherty#74

@leighmcculloch
Copy link
Owner Author

@mef I'm not very experienced with npm package.json files. Does this meet all the requirements?

@mef
Copy link

mef commented Jun 4, 2016

@leighmcculloch Thanks!

A comma is missing at the end of line 5, making the JSON invalid.

$ npm install git://github.com/leighmcculloch/gascrolldepth.js.git#add-npm-package.json
# (...)
npm ERR! code EJSONPARSE

npm ERR! Failed to parse json
npm ERR! Unexpected token 'r' at 6:4

@leighmcculloch
Copy link
Owner Author

@mef Fixed. How are we looking now?

@mef
Copy link

mef commented Jun 4, 2016

I'm afraid there's a trailing comma at the end of line 10, preventing the file to parse correctly.

@mef
Copy link

mef commented Jun 4, 2016

Rest of the file is good, I have checked :)

@leighmcculloch
Copy link
Owner Author

@mef Oh dear, thank you for your patience! I don't use npm much and I'm sick in bed so I thought I'd just wing it. I just actually tested it this time and it should be good now.

@mef
Copy link

mef commented Jun 4, 2016

Thank you so much!

I confirm that it works well now :)

@leighmcculloch leighmcculloch merged commit 7083403 into master Jun 4, 2016
@leighmcculloch leighmcculloch deleted the add-npm-package.json branch June 4, 2016 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants