Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all sample extensions' main.ts #24

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Fix all sample extensions' main.ts #24

merged 1 commit into from
Nov 19, 2021

Conversation

Nokel81
Copy link
Contributor

@Nokel81 Nokel81 commented Nov 19, 2021

Signed-off-by: Sebastian Malton sebastian@malton.name

@Nokel81
Fix all sample extensions' main.ts
83efd96 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added the bug Something isn't working label Nov 19, 2021
jim-docker
jim-docker approved these changes Nov 19, 2021
View reviewed changes
Copy link

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, probably a copy/paste error when we switched from LensMainExtension, etc?

@Nokel81
Copy link
Contributor Author

Nokel81 commented Nov 19, 2021

Yes probably

@Nokel81 Nokel81 merged commit 7ee200c into master Nov 19, 2021
@Nokel81 Nokel81 deleted the fix/all-samples branch November 19, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-docker jim-docker jim-docker approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nokel81 @jim-docker