Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pod details to hello-world #5

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Add pod details to hello-world #5

merged 2 commits into from
Nov 12, 2020

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Nov 12, 2020 •
edited
Loading

image

@jakolehm
add pod details to hello-world
481a287 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
typesafe props
3d759cc 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
nevalla
nevalla approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit 840a287 into master Nov 12, 2020
@jakolehm jakolehm deleted the hello-pod-details branch November 12, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevalla nevalla nevalla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakolehm @nevalla