Merge pull request #80 from leonardt/fail-old

Make sure old style constructors fail properly
leonardt · Jul 25, 2019 · acb4834 · acb4834
2 parents 2bc4bd9 + 5ee0bd3
commit acb4834
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/hwtypes/bit_vector_abc.py b/hwtypes/bit_vector_abc.py
@@ -41,7 +41,7 @@ def __call__(cls, value=_MISSING, *args, **kwargs):
             else:
                 raise TypeError('Cannot construct {} from {}'.format(cls, value))
 
-        return type(cls).__call__(cls[size], value)
+        return type(cls).__call__(cls[size], value, *args, **kwargs)
 
 
     def __new__(mcs, name, bases, namespace, info=(None, None), **kwargs):

diff --git a/tests/test_bv.py b/tests/test_bv.py
@@ -107,3 +107,14 @@ def test_deprecated(val):
     with pytest.warns(DeprecationWarning):
         BitVector(val)
 
+@pytest.mark.parametrize("val", [
+        BitVector.random(4),
+        BitVector.random(4).as_sint(),
+        BitVector.random(4).as_uint(),
+        [0,1,1,0],
+    ])
+def test_old_style(val):
+    with pytest.warns(DeprecationWarning):
+        with pytest.raises(TypeError):
+            BitVector(val, 4)
+