Use vendored dependencies #73
Comments
jsha
pushed a commit
that referenced
this issue
Dec 18, 2018
* Fixes the `cttestsrv` API breakage with Trillian master from time source refactoring. * Updates the project/CI to use Go 1.11.x * Configures a `ct-woodpecker` module * Vendors dependencies[0] * Removes `errcheck`[1] from CI * Updates CI to use vendored deps throughout * Fixes a few typos flagged by Goreportcard Resolves #72 and #73 and fixes CI. [0]: Notably this pins Trillian to d0c8d5f - the tip of master at the time of writing. We're using changes that aren't in the latest v1.2.1 tag. Similarly, Trillian at tip of master requires us to pin golang/protobuf at 1d3f30b - the tip of master for that project at the time of writing. Trillian is using changes in this project that aren't in the latest v1.2.0 tag. [1]: Errcheck doesn't work with Go modules and our vendored deps. Adding it back is blocked on kisielk/errcheck#155 Personally I think the stability improvements of vendored dependencies merits removing errcheck from Travis and the cron builds. We do still get `errcheck` coverage per-PR with [GolangCI](https://golangci.com/).
|
This was resolved by #74. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should convert this repo to use Go modules & to vendor dependencies. This will avoid upstream drift from breaking the build. (E.g. #72)
The text was updated successfully, but these errors were encountered: