Better typespecs #367
Merged
Better typespecs #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our protocol types were rather weak, relying on most of the structs
defining their type as `@type t :: %__MODULE__{}`. We can do _much_
better than that, since we have detailed infomration about the entire
type hierarchy.
This commit does that providing detailed type information for the
created structs and their constructors.
I also found a couple of cases where the generators would miss type
aliases that were just aliases to "base" types, like strings,
integers, etc.
zachallaun
reviewed
Sep 14, 2023
I considerd this, your comment confirms my hunch, I'll change it. |
Fixed missed cases for typespecs, fixed unit test that was asserting the wrong value type.
zachallaun
reviewed
Sep 14, 2023
zachallaun
reviewed
Sep 14, 2023
zachallaun
reviewed
Sep 14, 2023
zachallaun
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has three commits, the first is the biggest, and adds (very) detailed type information to our generated modules. Thanks to this, i found a couple legit bugs in the code.
I also had to nudge the generators slightly in order to get them to generate base types, which were missing from the codebase. Since the missing things were just aliases to base types, stuff would still work.