-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Upgrade expo react native Type #24
Conversation
Hey @bonsaibauer, give this branch a try. There is a separate outstanding issue being worked on related to certain image upload URLs (you would see an error message in dev mode like "upload://3j21k1l...") from specific posts. We're hoping to get to the bottom of that one relatively soon. |
Yarn test run/NPM test run was successful, no issues, thank you very much for your engagement @Kinostrome @starjustice !
|
1858401
to
4f0a863
Compare
bc0d768
to
3ad8f15
Compare
Hey, @bonsaibauer, thank you for testing these changes. Regarding the warnings about "unmet peer dependencies," This should not be an issue for you. This warning occurs when a package being installed has peer dependencies that are not installed or are not satisfied with the installed versions. In general, a dependency is a library or package that your project needs to run, while a peer dependency is used to indicate a library or package that your project will hook into. In this case, the warnings are showing because some packages are still using older versions of peer dependencies. However, some of these packages, such as react-native-keyboard-accessory, are already compatible with Expo. I don't think there will be any errors or issues when trying to use these packages in the app. As for some dev packages like graphql-codegen, they should not cause any issues for the app. This package is only used to generate GraphQL types from the API, which can be used in the frontend code. |
Thank you for the detailed and understandable explanation @starjustice |
Hi @starjustice and @Kinostrome, Do you happen to know if this PR is planned for merging? I can confirm, that using the master branch I was unable to even load up the Lexicon app within an Android emulator. However, using this PR, I was able to load up the app within the emulator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to improve some of the issues with v1
hey @SimonBiggs, I will merge this PR. And thanks for your work on PR #36 to try to fix the issue in the master branch to make the app works. |
My pleasure, thank you for all your work building this brilliant Discourse app :) |
Type of PR
style:
andperf:
commits)Description
Changes
Date: Monday, 10 Apr 2023
Contextual Changes:
ImagePickerResult
cancelled to canceledImagePickerResult
using assetsDate: Wed, 12 Apr 2023
Contextual Changes:
.eslintrc.json
@typescript-eslint/eslint-plugin
@typescript-eslint/parser
eslint-config-prettier
eslint-plugin-eslint-comments
eslint-plugin-prettier
eslint-plugin-react
eslint-plugin-react-hooks
eslint-plugin-react-native
eslint-plugin-styles
eslint-plugin-t
Additional Screenshots
Provide screenshot if necessary.
Additional information/context
If relevant, add any information or context that would be useful to evaluate this PR