Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Upgrade expo react native Type #24

Merged
merged 8 commits into from
Jun 26, 2023

Conversation

starjustice
Copy link
Collaborator

@starjustice starjustice commented Apr 10, 2023

Type of PR

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (adding a feature following a feature-request issue)
  • Improvement (improving an existing feature - includes style: and perf:commits)
  • Refactor (rewriting existing code without any feature change)
  • (!) This change is or requires a documentation update

Description

Changes

Date: Monday, 10 Apr 2023

Contextual Changes:

Date: Wed, 12 Apr 2023

Contextual Changes:

  • add new eslint config in file .eslintrc.json
  • add new devDep for eslint
    • @typescript-eslint/eslint-plugin
    • @typescript-eslint/parser
    • eslint-config-prettier
    • eslint-plugin-eslint-comments
    • eslint-plugin-prettier
    • eslint-plugin-react
    • eslint-plugin-react-hooks
    • eslint-plugin-react-native
    • eslint-plugin-styles
    • eslint-plugin-t
  • Change new typescript version

Additional Screenshots

Provide screenshot if necessary.

Additional information/context

If relevant, add any information or context that would be useful to evaluate this PR

@starjustice starjustice changed the title Upgrade expo react Fix Upgrade expo react Type Apr 10, 2023
@starjustice starjustice changed the title Fix Upgrade expo react Type Fix Upgrade expo react native Type Apr 10, 2023
@Kinostrome
Copy link
Contributor

Hey @bonsaibauer, give this branch a try.

There is a separate outstanding issue being worked on related to certain image upload URLs (you would see an error message in dev mode like "upload://3j21k1l...") from specific posts. We're hoping to get to the bottom of that one relatively soon.

@bonsaibauer
Copy link

bonsaibauer commented Apr 10, 2023

Yarn test run/NPM test run was successful, no issues, thank you very much for your engagement @Kinostrome @starjustice !

This was referenced Apr 12, 2023
@starjustice
Copy link
Collaborator Author

  • I am confused about all the warnings regarding "has unmet per dependency." What are the implications of these warnings?

Hey, @bonsaibauer, thank you for testing these changes.

Regarding the warnings about "unmet peer dependencies," This should not be an issue for you. This warning occurs when a package being installed has peer dependencies that are not installed or are not satisfied with the installed versions.

In general, a dependency is a library or package that your project needs to run, while a peer dependency is used to indicate a library or package that your project will hook into.

In this case, the warnings are showing because some packages are still using older versions of peer dependencies. However, some of these packages, such as react-native-keyboard-accessory, are already compatible with Expo. I don't think there will be any errors or issues when trying to use these packages in the app.

As for some dev packages like graphql-codegen, they should not cause any issues for the app. This package is only used to generate GraphQL types from the API, which can be used in the frontend code.

@bonsaibauer
Copy link

bonsaibauer commented Apr 18, 2023

Thank you for the detailed and understandable explanation @starjustice
I'm glad I could help, and there are several aspects that I now understand.

@SimonBiggs
Copy link
Contributor

SimonBiggs commented Jun 1, 2023

Hi @starjustice and @Kinostrome,

Do you happen to know if this PR is planned for merging?

I can confirm, that using the master branch I was unable to even load up the Lexicon app within an Android emulator. However, using this PR, I was able to load up the app within the emulator.

Copy link
Contributor

@Kinostrome Kinostrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to improve some of the issues with v1

@starjustice
Copy link
Collaborator Author

Hi @starjustice and @Kinostrome,

Do you happen to know if this PR is planned for merging?

I can confirm, that using the master branch I was unable to even load up the Lexicon app within an Android emulator. However, using this PR, I was able to load up the app within the emulator.

hey @SimonBiggs,

I will merge this PR. And thanks for your work on PR #36 to try to fix the issue in the master branch to make the app works.

@starjustice starjustice merged commit 25dc6dc into lexiconhq:master Jun 26, 2023
@SimonBiggs
Copy link
Contributor

And thanks for your work on PR #36

My pleasure, thank you for all your work building this brilliant Discourse app :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants