Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): scan table acc #2944

Merged
merged 4 commits into from
Jun 25, 2024
Merged

refactor(node): scan table acc #2944

merged 4 commits into from
Jun 25, 2024

Conversation

ngjaying
Copy link
Collaborator

Do batch in join align node

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (master-v2@ee10892). Learn more about missing BASE report.

Files Patch % Lines
internal/topo/planner/planner_source.go 75.00% 2 Missing and 2 partials ⚠️
internal/topo/node/source_node.go 86.67% 1 Missing and 1 partial ⚠️
internal/topo/planner/planner.go 81.82% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master-v2    #2944   +/-   ##
============================================
  Coverage             ?   69.88%           
============================================
  Files                ?      311           
  Lines                ?    29753           
  Branches             ?        0           
============================================
  Hits                 ?    20790           
  Misses               ?     7171           
  Partials             ?     1792           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying force-pushed the v2scan branch 3 times, most recently from 79424bf to 4b8d9ed Compare June 24, 2024 09:37
Do batch in join align node

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying marked this pull request as ready for review June 24, 2024 09:59
@ngjaying ngjaying requested a review from Yisaer June 24, 2024 09:59
@ngjaying ngjaying merged commit 2baffea into lf-edge:master-v2 Jun 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants