Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revise connection api #3159

Merged
merged 3 commits into from
Sep 2, 2024
Merged

fix: revise connection api #3159

merged 3 commits into from
Sep 2, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Aug 30, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 73.80952% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.16%. Comparing base (29e56e7) to head (85adcd3).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
pkg/connection/connection_pool.go 66.67% 4 Missing and 2 partials ⚠️
internal/server/connection.go 79.17% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
+ Coverage   70.97%   71.16%   +0.19%     
==========================================
  Files         397      397              
  Lines       43085    43044      -41     
==========================================
+ Hits        30577    30630      +53     
+ Misses      10111    10001     -110     
- Partials     2397     2413      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
@ngjaying ngjaying merged commit c3e2e86 into lf-edge:master Sep 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants