Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connection): support connection status change #3171

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Sep 5, 2024

  • Notify status change in source/sink
  • Export the disconnect info to rule metric

@ngjaying ngjaying force-pushed the v2connection branch 6 times, most recently from f73a338 to e032b3a Compare September 5, 2024 03:51
- Notify status change in source/sink
- Export the disconnect info to rule metric

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 78.00512% with 86 lines in your changes missing coverage. Please review.

Project coverage is 71.18%. Comparing base (49b68a1) to head (05d0a1e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/io/mqtt/client/client.go 73.02% 12 Missing and 5 partials ⚠️
pkg/connection/connection_pool.go 88.43% 11 Missing and 3 partials ⚠️
internal/io/http/httpserver/websocketConn.go 61.29% 8 Missing and 4 partials ⚠️
internal/io/edgex/client/edgex.go 52.38% 7 Missing and 3 partials ⚠️
extensions/impl/sql/client/client.go 59.09% 6 Missing and 3 partials ⚠️
pkg/connection/connection_mock.go 71.43% 4 Missing ⚠️
pkg/nng/sock.go 73.33% 4 Missing ⚠️
internal/io/neuron/connector.go 62.50% 2 Missing and 1 partial ⚠️
extensions/impl/sql/sink.go 0.00% 2 Missing ⚠️
internal/binder/mock/mock_factory.go 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3171      +/-   ##
==========================================
+ Coverage   71.16%   71.18%   +0.02%     
==========================================
  Files         385      385              
  Lines       43142    43187      +45     
==========================================
+ Hits        30698    30740      +42     
+ Misses      10020    10018       -2     
- Partials     2424     2429       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review September 5, 2024 05:42
@ngjaying ngjaying requested a review from Yisaer September 5, 2024 05:42
@ngjaying ngjaying merged commit 7248c66 into lf-edge:master Sep 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants