Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support local span storage #3176

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Sep 6, 2024

No description provided.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 66.84492% with 62 lines in your changes missing coverage. Please review.

Project coverage is 71.18%. Comparing base (0d5c110) to head (44a245c).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
pkg/tracer/manager.go 76.35% 30 Missing and 5 partials ⚠️
internal/server/tracer.go 0.00% 11 Missing ⚠️
internal/pkg/store/sql/stores_builder.go 30.77% 6 Missing and 3 partials ⚠️
pkg/tracer/tracer.go 0.00% 4 Missing ⚠️
internal/pkg/store/setup.go 66.67% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3176      +/-   ##
==========================================
+ Coverage   71.13%   71.18%   +0.05%     
==========================================
  Files         386      386              
  Lines       43210    43453     +243     
==========================================
+ Hits        30736    30931     +195     
- Misses      10041    10083      +42     
- Partials     2433     2439       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying September 9, 2024 07:04
@Yisaer Yisaer marked this pull request as ready for review September 9, 2024 07:04
internal/pkg/store/setup.go Show resolved Hide resolved
internal/pkg/store/setup.go Show resolved Hide resolved
@ngjaying ngjaying merged commit d861001 into lf-edge:master Sep 11, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants