Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connection): nng as stateful dialer #3180

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Sep 9, 2024

No description provided.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (d752170) to head (ac3bee5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/io/mqtt/client/client.go 71.43% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
- Coverage   71.14%   71.12%   -0.02%     
==========================================
  Files         386      386              
  Lines       43290    43309      +19     
==========================================
+ Hits        30797    30800       +3     
- Misses      10057    10071      +14     
- Partials     2436     2438       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying requested a review from Yisaer September 9, 2024 06:27
@ngjaying ngjaying marked this pull request as ready for review September 9, 2024 06:43
@ngjaying ngjaying merged commit 4a313cd into lf-edge:master Sep 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants