chore: 修改 replaceText 的实现,减少没必要的 deepClone (baidu#9399)

lhtuling · Jan 10, 2024 · d48c516 · d48c516
1 parent 1d7efdc
commit d48c516
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 15 deletions.
diff --git a/packages/amis-core/src/index.tsx b/packages/amis-core/src/index.tsx
@@ -311,6 +311,7 @@ function AMISRenderer({
 
   // 根据环境覆盖 schema，这个要在最前面做，不然就无法覆盖 validations
   schema = envOverwrite(schema, locale);
+  // todo 和 envOverwrite 一起处理，减少循环次数
   schema = replaceText(schema, options.replaceText, env.replaceTextIgnoreKeys);
 
   return (

diff --git a/packages/amis-core/src/utils/replaceText.ts b/packages/amis-core/src/utils/replaceText.ts
@@ -2,7 +2,7 @@
  * 对文本进行替换
  */
 import cloneDeep from 'lodash/cloneDeep';
-import {isObject, JSONTraverse} from './helper';
+import {isObject, JSONValueMap} from './helper';
 
 export function replaceText(
   schema: any,
@@ -13,8 +13,10 @@ export function replaceText(
 ) {
   // 进行文本替换
   if (replaceText && isObject(replaceText)) {
-    let replicaSchema = cloneDeep(schema);
     const replaceKeys = Object.keys(replaceText);
+    if (!replaceKeys.length) {
+      return schema;
+    }
     replaceKeys.sort((a, b) => b.length - a.length); // 避免用户将短的放前面
     const IgnoreKeys = new Set(
       Array.isArray(replaceTextIgnoreKeys) ? replaceTextIgnoreKeys : []
@@ -26,25 +28,16 @@ export function replaceText(
             return IgnoreKeys.has(key);
           };
 
-    JSONTraverse(replicaSchema, (value: any, key: string, object: any) => {
-      const descriptor = Object.getOwnPropertyDescriptor(object, key);
-      if (
-        typeof value === 'string' &&
-        descriptor?.writable &&
-        !ignore(key, value, object)
-      ) {
+    return JSONValueMap(schema, (value: any, key: string, object: any) => {
+      if (typeof value === 'string' && !ignore(key, value, object)) {
         for (const replaceKey of replaceKeys) {
           if (~value.indexOf(replaceKey)) {
-            value = object[key] = value.replaceAll(
-              replaceKey,
-              replaceText[replaceKey]
-            );
+            return value.replaceAll(replaceKey, replaceText[replaceKey]);
           }
         }
       }
+      return value;
     });
-
-    return replicaSchema;
   }
   return schema;
 }