Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of allocfmt() #449

Merged
merged 1 commit into from
Nov 10, 2014
Merged

Get rid of allocfmt() #449

merged 1 commit into from
Nov 10, 2014

Conversation

carlosmn
Copy link
Member

@carlosmn carlosmn commented Nov 9, 2014

It is not possible to know how we can free the results of this
allocation, so we shouldn't be using this function.

We have a convention of returning Oid objects in pygit2, so let's keep
to that in these places.


The tests showed some issues if we just leave it to use str or repr to compare, though it likely won't affect anybody who is using this to print them out. So this may be a breaking change in certain situations.

It is not possible to know how we can free the results of this
allocation, so we shouldn't be using this function.

We have a convention of returning Oid objects in pygit2, so let's keep
to that in these places.
@jdavid jdavid merged commit 11eea2d into libgit2:master Nov 10, 2014
jdavid added a commit that referenced this pull request Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants