Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mxinden as maintainer to universal connectivity #140

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Mar 29, 2023

Summary

Add myself as maintainer to the universal connectivy repository in order to push to libp2p/universal-connectivity#3.

Why do you need this?

Want to push a fix for the missing SUBSCRIBE.

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@mxinden mxinden requested a review from p-shahi March 29, 2023 13:50
@mxinden mxinden requested review from a team as code owners March 29, 2023 13:50
@github-actions
Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_repository_collaborator.this["universal-connectivity:mxinden"] will be created
  + resource "github_repository_collaborator" "this" {
      + id                          = (known after apply)
      + invitation_id               = (known after apply)
      + permission                  = "maintain"
      + permission_diff_suppression = false
      + repository                  = "universal-connectivity"
      + username                    = "mxinden"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@mxinden mxinden merged commit 8d2f751 into master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants