return a ConnectionStat instead of a Stat for the Conn

[marten-seemann]

This allows us to expose the number of streams that are currently open on a connection, which will allow us to prioritize killing of connections with many streams in the connection manager.

[vyzo]

We probably should call it ConnStat as we don't spell it fully anywhere; other than that LGTM.

[vyzo]

Let's call it ConnStat for consistency?

[marten-seemann]

I'd love to, but ConnStat is already the interface:

go-libp2p-core/network/conn.go

Lines 63 to 67 in 975f71b

	// ConnStat is an interface mixin for connection types that provide connection statistics.
	type ConnStat interface {
	// Stat stores metadata pertaining to this conn.
	Stat() Stat
	}

[github-actions]

gocompat says:

Branch 'master' set up to track remote branch 'master' from 'origin'.
"github.com/libp2p/go-libp2p-core/network".ConnStat InterfaceChanged
"github.com/libp2p/go-libp2p-core/network".Conn InterfaceChanged

[vyzo]

Ouch.... oh well.

…

On Fri, Dec 10, 2021, 13:19 Marten Seemann ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In network/network.go <#224 (comment)>: > @@ -96,7 +96,14 @@ func (r Reachability) String() string { return str[r] } -// Stat stores metadata pertaining to a given Stream/Conn. +// ConnectionStat stores metadata pertaining to a given Conn. +type ConnectionStat struct { I'd love to, but ConnStat is already the interface: https://github.com/libp2p/go-libp2p-core/blob/975f71b238330cbfafb4a96f674ff047686dc219/network/conn.go#L63-L67 — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#224 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAI4SQ6LQQYKJC66UE7DL3UQHO5XANCNFSM5JY3KYXA> .