Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade deps + uvarint delimited writer/reader. #684

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

raulk
Copy link
Member

@raulk raulk commented Jul 29, 2020

This fixes minor interoperability issues we found with other implementations of libp2p wrt. length-prefixing, and also does a routine dependency upgrade, since I'm on it.

@raulk raulk force-pushed the deps-uvarints branch 3 times, most recently from 1bfba46 to d76aca7 Compare July 30, 2020 10:27
@aarshkshah1992 aarshkshah1992 self-assigned this Jul 30, 2020
@aarshkshah1992 aarshkshah1992 self-requested a review July 30, 2020 10:42
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@raulk raulk merged commit fc3558c into master Jul 30, 2020
@raulk raulk deleted the deps-uvarints branch July 30, 2020 11:29
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants