Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add logs to composable parallel #63

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

ajnavarro
Copy link
Member

@ajnavarro ajnavarro commented Dec 1, 2022

Adding logs on composableParallel to make it possible to debug errors or strange behaviors. Some context about this change here: ipfs/kubo#9445

@ajnavarro ajnavarro self-assigned this Dec 1, 2022
@ajnavarro ajnavarro changed the title Add logs to composable parallel chore: Add logs to composable parallel Dec 1, 2022
@BigLep
Copy link

BigLep commented Dec 2, 2022

@ajnavarro : can we give more context on why we're doing this change? Is there an issue this should be connected to?

Does this pertain to the issue Cloudflare (and EngRes Bifrost) observed on their gateways with 0.17 (https://protocollabs.slack.com/archives/C01KN5SS27K/p1669768982120149)?

@ajnavarro
Copy link
Member Author

@BigLep updated PR description.

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro force-pushed the chore/add-logs-to-composable-parallel branch from b514e32 to 2619e85 Compare December 5, 2022 11:13
@ajnavarro ajnavarro merged commit 6aac34b into master Dec 5, 2022
@ajnavarro ajnavarro deleted the chore/add-logs-to-composable-parallel branch December 5, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants