Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

only listen on localhost in tests #238

Merged
merged 1 commit into from
Feb 9, 2021
Merged

only listen on localhost in tests #238

merged 1 commit into from
Feb 9, 2021

Conversation

marten-seemann
Copy link
Contributor

OSX complains when you listen on all interfaces:
Screen Shot 2021-02-09 at 11 09 34

Stebalien
Stebalien approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. And if it doesn't, we need to fix the tests that fail anyways.

@Stebalien Stebalien merged commit 0f85476 into master Feb 9, 2021
@Stebalien Stebalien deleted the fix-global-listen-in-tests branch February 9, 2021 03:45
@Stebalien Stebalien mentioned this pull request May 11, 2021
Closed
27 tasks
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
Closed
71 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@aarshkshah1992 aarshkshah1992 Awaiting requested review from aarshkshah1992

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @Stebalien