Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

New Dialer #243

Merged
merged 33 commits into from
Apr 1, 2021
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
1dde927
fix: prefer non-transient connections
Stebalien Mar 19, 2021
d73f313
fix: DRY direct connect logic
Stebalien Mar 19, 2021
14d544b
fix: do not use the request context when dialing
Stebalien Mar 19, 2021
8930f29
deps: update go-libp2p-core
vyzo Mar 30, 2021
9d50a8c
implement dial worker for synchronizing simultaneous dials
vyzo Mar 30, 2021
201a8d1
adjust next dial delays
vyzo Mar 30, 2021
2e742fb
fix dial_sync tests
vyzo Mar 30, 2021
5900641
clear address dial when they fail because of backoff
vyzo Mar 30, 2021
de528f1
nuke incref, it's useless
vyzo Mar 31, 2021
2ee7bf0
make dialWorker return an error for self dials and responsible for sp…
vyzo Mar 31, 2021
0510dcb
don't use a goroutine for the actual dial
vyzo Mar 31, 2021
96723d1
bump go version to 1.15
vyzo Mar 31, 2021
bbd0a01
batch dials together, rework address ranking
vyzo Mar 31, 2021
a6c2838
tune down batch dial delays
vyzo Mar 31, 2021
7ccf58e
use a timer instead of time.After
vyzo Mar 31, 2021
0fc0ade
kill dial jump delays
vyzo Mar 31, 2021
12a0cdb
add TestDialExistingConnection
vyzo Mar 31, 2021
e7b6af6
do a last ditch check for acceptable connections before dispatching a…
vyzo Mar 31, 2021
580a818
merge dial contexts where possible
vyzo Mar 31, 2021
699b4d1
add TestDialSimultaneousJoin test
vyzo Mar 31, 2021
b67b736
don't add backoff if we have successfully connected
vyzo Mar 31, 2021
0538806
fix TestConnectednessCorrect
vyzo Mar 31, 2021
acc35e8
don't store the active dial if it errors while starting the worker
vyzo Mar 31, 2021
27f6c39
add TestSelfDial
vyzo Mar 31, 2021
1624828
make DialRequest and DialResponse private
vyzo Apr 1, 2021
13d3556
add comment about the necessity of removing the address tracking when…
vyzo Apr 1, 2021
4a69fa2
remove dial batching
vyzo Apr 1, 2021
43b0382
add new TestDialSelf
vyzo Apr 1, 2021
17bc04b
make DialWorkerFunc, NewDialSync private
vyzo Apr 1, 2021
be3e940
rename dialWorker to startDialWorker
vyzo Apr 1, 2021
df0ab8b
make addr utility funcs standalone and not exported
vyzo Apr 1, 2021
084fffe
make IsFdConsumingAddr a standalone utility func
vyzo Apr 1, 2021
fe4ee0b
Merge pull request #250 from libp2p/fix/simultaneous-dial
vyzo Apr 1, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clear address dial when they fail because of backoff
makes TestDialBackoff happy
  • Loading branch information
vyzo committed Mar 30, 2021
commit 59006419d1b7a2441726c752b27ccf0df0bd4359
5 changes: 5 additions & 0 deletions swarm_dial.go
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,11 @@ loop:
delete(requests, reqno)
}
}

// if it was a backoff, clear the address dial so that it doesn't inhibit new dial requests
if res.err == ErrDialBackoff {
delete(pending, res.addr)
}
}
}
}
Expand Down