libp2phttp: Rename well-known resource #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
approved these changes
Apr 11, 2024
lidel
added a commit
to ipfs/specs
that referenced
this pull request
Apr 19, 2024
Changed in libp2p spec draft and go-libp2p: libp2p/specs#508 (comment) libp2p/specs@3c0ac40 libp2p/go-libp2p#2757
gammazero
reviewed
May 16, 2024
| @@ -30,6 +30,7 @@ import ( | |||
| var log = logging.Logger("libp2phttp") | |||
|
|
|||
| const ProtocolIDForMultistreamSelect = "/http/1.1" | |||
| const WellKnownProtocols = "/.well-known/libp2p/protocols" | |||
There was a problem hiding this comment.
@MarcoPolo Changing this from "/.well-known/libp2p" to "/.well-known/libp2p/protocols" will break the ability to communicate with existing servers deployed without upgrading them first. Since these servers are running in places not under our control, they will not be immediately upgradable.
This means that libp2phttp needs to support both the old and the new values, or revert to using the old value.
Since there are already deployments using the old value, I suggest changing this to:
const WellKnownProtocols = "/.well-known/libp2p"
gammazero
added a commit
that referenced
this pull request
May 16, 2024
Changing from "/.well-known/libp2p" to "/.well-known/libp2p/protocols" will break the ability to communicate with existing servers deployed without upgrading them first. Since these servers are running in places not under our control, they will not be immediately upgradable. This means that libp2phttp needs to support both the old and the new values, or revert to using the old value. This PR reverts to using the old resource name, which was changed in #2757.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming the well-known libp2p http resource. Context here: libp2p/specs#508 (comment)