Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce usage of goto #40

Merged
merged 1 commit into from
Feb 16, 2021
Merged

reduce usage of goto #40

merged 1 commit into from
Feb 16, 2021

Conversation

marten-seemann
Copy link
Contributor

Arguably, using goto is bad coding style.
I can accept it when it's used to avoid a loop, but not for performing wild jumps all over the place.

willscott
willscott approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these are indeed only being goto'd in one place this does seem like it makes the code much saner

@marten-seemann marten-seemann merged commit e8e3876 into master Feb 16, 2021
@marten-seemann marten-seemann deleted the reduce-goto-usage branch February 16, 2021 05:39
@Stebalien Stebalien mentioned this pull request May 11, 2021
Closed
27 tasks
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @willscott