Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get the daemon working outside of tests #127

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

saul-jb
Copy link

@saul-jb saul-jb commented Sep 10, 2022

I have had a go at fixing the problems with running the daemon outside the libp2p interop suite as discussed in issue #83.

  • I have updated the libp2p-daemon-client stream.spec.ts test because it-handshake returns a Uint8ArrayList not a Uint8Array
  • I have fixed a couple minor type issues around the it-handshake types that was making the compile fail.
  • The libp2p-daemon tests have been enabled and updated.
  • Removes the dated yargs-promise.
  • Added psk, pubsubDiscovery, discoveryInterval and relay specific cli arguments.

@saul-jb saul-jb marked this pull request as draft September 11, 2022 22:57
@saul-jb saul-jb marked this pull request as ready for review September 11, 2022 23:09
@saul-jb saul-jb marked this pull request as ready for review September 13, 2022 00:29
@saul-jb
Copy link
Author

saul-jb commented Sep 14, 2022

This now works with UNIX domain sockets!

@achingbrain achingbrain changed the title Get the daemon working outside of tests. fix: get the daemon working outside of tests Sep 23, 2022
@mpetrunic mpetrunic linked an issue Oct 4, 2022 that may be closed by this pull request
packages/libp2p-daemon/package.json Outdated Show resolved Hide resolved
packages/libp2p-daemon/package.json Outdated Show resolved Hide resolved
packages/libp2p-daemon/src/index.ts Outdated Show resolved Hide resolved
@saul-jb
Copy link
Author

saul-jb commented Nov 2, 2022

A couple of notes:

@saul-jb saul-jb requested review from mpetrunic and removed request for achingbrain and wemeetagain November 2, 2022 00:26
@p-shahi p-shahi added this to the Best Effort Track milestone Nov 22, 2022
@p-shahi p-shahi added the P2 Medium: Good to have, but can wait until someone steps up label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daemon cli not working as expected
3 participants