This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
fix: close streams when connection is closed #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for closeRead and closeWrite on the muxer streams. Also: - Removed libp2p-tcp in favor of it-pair to avoid circular deps - Connection.close() will now close its internal streams to avoid lingering streams. Supersedes #90 BREAKING CHANGE: This adds closeWrite and closeRead checks in the tests, which will cause test failures for muxers that don't implement those
If you are `.abort()`ing a stream, pass an error, otherwise call `.close()`
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
May 19, 2022
Make sure we don't leave streams open. Depends on: - libp2p/js-libp2p-interfaces#214 - libp2p/js-libp2p-mplex#170
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2022
## [@libp2p/interfaces-v2.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interfaces-v1.3.32...@libp2p/interfaces-v2.0.0) (2022-05-20) ### ⚠ BREAKING CHANGES * This adds closeWrite and closeRead checks in the tests, which will cause test failures for muxers that don't implement those ### Bug Fixes * close streams when connection is closed ([#214](#214)) ([88fcd58](88fcd58)), closes [#90](#90)
|
🎉 This PR is included in version @libp2p/interfaces-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2022
## [@libp2p/interface-compliance-tests-v2.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-compliance-tests-v1.1.34...@libp2p/interface-compliance-tests-v2.0.0) (2022-05-20) ### ⚠ BREAKING CHANGES * This adds closeWrite and closeRead checks in the tests, which will cause test failures for muxers that don't implement those ### Bug Fixes * close streams when connection is closed ([#214](#214)) ([88fcd58](88fcd58)), closes [#90](#90) * update interfaces ([#215](#215)) ([72e6890](72e6890))
|
🎉 This PR is included in version @libp2p/interface-compliance-tests-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2022
## [@libp2p/connection-v2.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/connection-v1.1.5...@libp2p/connection-v2.0.0) (2022-05-20) ### ⚠ BREAKING CHANGES * This adds closeWrite and closeRead checks in the tests, which will cause test failures for muxers that don't implement those ### Bug Fixes * close streams when connection is closed ([#214](#214)) ([88fcd58](88fcd58)), closes [#90](#90) * update interfaces ([#215](#215)) ([72e6890](72e6890))
|
🎉 This PR is included in version @libp2p/connection-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for closeRead and closeWrite on the muxer streams.
Also:
Supersedes #90
BREAKING CHANGE: This adds closeWrite and closeRead checks in the tests, which will cause test failures for muxers that don't implement those