This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
chore: add duplex iterable type to connection #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
chore/add-duplex-iterable-type-to-connection
branch
from
88f32fd
to
91289ba
Compare
vasco-santos
force-pushed
the
chore/add-duplex-iterable-type-to-connection
branch
from
91289ba
to
be84a4b
Compare
1 task
jacobheun
reviewed
Nov 25, 2020
| export type DuplexIterableStream = { | ||
| sink: Sink; | ||
| source: () => AsyncIterator<Uint8Array, any, undefined>; | ||
| }; |
There was a problem hiding this comment.
The type here should really just be a Stream, and it should match what's coming from mplex https://github.com/libp2p/js-libp2p-mplex/blob/v0.10.1/src/stream.js#L59
There was a problem hiding this comment.
Should we add the Stream in a type declaration file in the multiplexer interface?
Gozala
reviewed
Nov 30, 2020
| * | ||
| * @typedef {object} DuplexIterableStream | ||
| * @property {Sink} sink | ||
| * @property {() AsyncIterator<Uint8Array>} source |
There was a problem hiding this comment.
Is this AsyncIterator or is it meant to be AsyncIterable ?
|
Closed in favour of #74 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the duplex iterable type to connection per libp2p/js-libp2p#802 (comment)
This already existed in the pubsub peer streams and it was moved into the conenction and linked from there
cc @wemeetagain (could not ask you direct review)