fix: use libp2p dialer

libp2p · Nov 22, 2019 · a0a8500 · a0a8500
1 parent 44054b2
commit a0a8500
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 21 deletions.
diff --git a/src/network.js b/src/network.js
@@ -117,9 +117,11 @@ class Network {
       throw errcode(new Error('Network is offline'), 'ERR_NETWORK_OFFLINE')
     }
 
-    this._log('sending to: %s', to.toB58String())
+    const id = to.toB58String()
+    this._log('sending to: %s', id)
 
-    const { stream } = await this.dht.dialer.dialProtocol(to, c.PROTOCOL_DHT)
+    const conn = await this.dht.dialer.connectToPeer(to)
+    const { stream } = await conn.newStream(c.PROTOCOL_DHT)
 
     return this._writeReadMessage(stream, msg.serialize())
   }
@@ -136,9 +138,12 @@ class Network {
       throw errcode(new Error('Network is offline'), 'ERR_NETWORK_OFFLINE')
     }
 
-    this._log('sending to: %s', to.toB58String())
+    const id = to.toB58String()
+    this._log('sending to: %s', id)
+
+    const conn = await this.dht.dialer.connectToPeer(to)
+    const { stream } = await conn.newStream(c.PROTOCOL_DHT)
 
-    const { stream } = await this.dht.dialer.dialProtocol(to, c.PROTOCOL_DHT)
     return this._writeMessage(stream, msg.serialize())
   }
 

diff --git a/test/network.spec.js b/test/network.spec.js
@@ -32,11 +32,11 @@ describe('Network', () => {
       const msg = new Message(Message.TYPES.PING, Buffer.from('hello'), 0)
 
       // mock dial
-      dht.dialer.dialProtocol = (peer, protocol) => {
-        expect(protocol).to.eql('/ipfs/kad/1.0.0')
-
+      dht.dialer.connectToPeer = () => {
         return {
-          stream: pair() // {source, sink} streams that are internally connected
+          newStream: () => {
+            return { stream: pair() } // {source, sink} streams that are internally connected
+          }
         }
       }
 
@@ -56,8 +56,7 @@ describe('Network', () => {
       const msg = new Message(Message.TYPES.PING, Buffer.from('hello'), 0)
 
       // mock it
-      dht.dialer.dialProtocol = async (peer, protocol) => {
-        expect(protocol).to.eql('/ipfs/kad/1.0.0')
+      dht.dialer.connectToPeer = async () => {
         const msg = new Message(Message.TYPES.FIND_NODE, Buffer.from('world'), 0)
 
         const data = []
@@ -95,7 +94,9 @@ describe('Network', () => {
         }
 
         return {
-          stream: { source, sink }
+          newStream: () => {
+            return { stream: { source, sink } }
+          }
         }
       }
 
@@ -119,9 +120,7 @@ describe('Network', () => {
       const msg = new Message(Message.TYPES.PING, Buffer.from('hello'), 0)
 
       // mock it
-      dht.dialer.dialProtocol = (peer, protocol) => {
-        expect(protocol).to.eql('/ipfs/kad/1.0.0')
-
+      dht.dialer.connectToPeer = () => {
         const source = (async function * () { // eslint-disable-line require-yield
           await delay(1000)
         })()
@@ -142,7 +141,9 @@ describe('Network', () => {
         }
 
         return {
-          stream: { source, sink }
+          newStream: () => {
+            return { stream: { source, sink } }
+          }
         }
       }
 

diff --git a/test/utils/test-dht.js b/test/utils/test-dht.js
@@ -27,6 +27,7 @@ class TestDHT {
 
   async _spawnOne (index, options = {}) {
     const regRecord = {}
+    const peerStore = new PeerBook()
 
     // Disable random walk by default for more controlled testing
     options = {
@@ -41,7 +42,7 @@ class TestDHT {
 
     p.multiaddrs.add(`/ip4/127.0.0.1/tcp/${port}/p2p/${p.id.toB58String()}`)
 
-    const dial = async (peer, protocol) => {
+    const connectToPeer = async (peer) => {
       const remotePeerB58 = peer.toB58String()
       const remoteDht = this.nodes.find(
         (node) => node.peerInfo.id.toB58String() === remotePeerB58
@@ -58,25 +59,26 @@ class TestDHT {
       await remoteOnConnect(p, c0)
 
       await remoteHandler({
-        protocol: protocol,
+        protocol: PROTOCOL_DHT,
         stream: c0.stream,
         connection: {
           remotePeer: p.id
         }
       })
 
       return {
-        stream: c1.stream
+        newStream: () => {
+          return { stream: c1.stream }
+        }
       }
     }
 
     const dht = new KadDHT({
       dialer: {
-        dial,
-        dialProtocol: dial
+        connectToPeer
       },
       registrar: createMockRegistrar(regRecord),
-      peerStore: new PeerBook(),
+      peerStore,
       peerInfo: p,
       validators: {
         v: {