This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update deps #98
chore: update deps #98
Changes from 3 commits
8873143
69e8d78
921e137
5486682
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface update requires discovery to be triggered to fulfil some tests, like we do in other discovery modules like: https://github.com/libp2p/js-libp2p-webrtc-star/blob/master/test/compliance.spec.js#L54
This is not the optimal solution though, and I would like to change the testing interface in the future to return multiple discovery modules instances and start them all when needed.