This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
chore: add err code for unknown signal server on dial #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
LGTM.
The test may be better in the form of
return expect(ws1.dial(maOffline)).to.eventually.be.rejected.and.have.property('code', 'ERR_UNKNOWN_SIGNAL_SERVER')since then any future broken behaviour would fail on an assertion instead of needing to throw an error but it's a minor nit.
achingbrain
reviewed
Apr 23, 2021
| return expect(ws1.dial(maOffline)).to.eventually.be.rejected.and.have.property('code', 'ERR_SIGNALLING_FAILED') | ||
| }) | ||
|
|
||
| it('dial unknown signal server, check promise rejected', async function () { |
There was a problem hiding this comment.
I'm surprised this didn't cause linting to fail - there's no await in this async function..
There was a problem hiding this comment.
Nor in the 'dial offline / non-exist()ent node on IPv4, check promise rejected' test
There was a problem hiding this comment.
interesting 🤔 That is true
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per ipfs/js-ipfs#3633