This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
feat: pass through middleware config, noDefaultRoute option (proposal) #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abetaev
force-pushed
the
feat/expose-middleware-config
branch
from
e264346
to
c0369b7
Compare
abetaev
force-pushed
the
feat/expose-middleware-config
branch
from
c0369b7
to
68d7345
Compare
abetaev
force-pushed
the
feat/expose-middleware-config
branch
from
68d7345
to
c7d444f
Compare
abetaev
force-pushed
the
feat/expose-middleware-config
branch
from
c7d444f
to
d7e23f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the proposal
as a user of webrtc-star transport i want finer control over signalling server middleware to be able to:
i had to explicitly set test runtimes in aegir config in transport package because somehow it was trying to run tests within webworker runtime which does not (yet?) support WebRTC. i have no explanation for that. i use
npm testcommand to run all tests