Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] fix node 15/16 install due to npm 7 changes #790

Closed
jacobheun opened this issue Oct 22, 2020 · 2 comments · Fixed by #866
Closed

[testing] fix node 15/16 install due to npm 7 changes #790

jacobheun opened this issue Oct 22, 2020 · 2 comments · Fixed by #866
Assignees
Labels
dx Developer Experience kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@jacobheun
Copy link
Contributor

Node 15 includes npm 7 which now automatically installs peer dependencies by default, https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/.

This change also affects how we're linking libp2p itself in the devDependencies to make integration testing with modules like gossipsub easier (as it requires libp2p as a peerDependency).

Ideally we'd remove the local integration testing of modules and instead run their test suites in CI and test only the core API in the libp2p test suite. In the immediate term we should find a workaround for "libp2p": "." being in the devDependencies.

@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) dx Developer Experience labels Oct 22, 2020
@vasco-santos
Copy link
Member

@jacobheun I would like to get to this soon, so that we can bump CI to 15 and have tests running in both active and current Node versions. It would be great to get to a migration path here before starting

Modules with libp2p as a peerDependency:

The main concern is that we will need to support node 14, which does not install the peer dependencies

@vasco-santos vasco-santos changed the title [testing] fix node 15 install due to npm 7 changes [testing] fix node 15/16 install due to npm 7 changes May 21, 2021
@lidel
Copy link
Member

lidel commented May 31, 2021

(note from triage) nearly done, waiting for #866

@lidel lidel added the P1 High: Likely tackled by core team if no one steps up label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants