Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructure pubsub tests #866

Merged
merged 5 commits into from
Jun 13, 2021
Merged

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Jan 21, 2021

This PR restructures the pubsub tests to not use the routers as devDependencies, delegating the ownership of the subsystem testing to the modules.

Node versions in CI were updated to be 14 and 16.

Needs:

Closes #790

First step of #857 and related to #790

@vasco-santos vasco-santos force-pushed the chore/restructure-pubsub-tests branch from c6498df to cfb20e1 Compare April 16, 2021 20:45
@vasco-santos vasco-santos force-pushed the chore/restructure-pubsub-tests branch 2 times, most recently from 5b370b8 to e2f1aa0 Compare May 25, 2021 10:34
@vasco-santos vasco-santos marked this pull request as ready for review May 28, 2021 12:12
@vasco-santos vasco-santos force-pushed the chore/restructure-pubsub-tests branch from 35d5b9d to d42f7f0 Compare May 28, 2021 12:21
@vasco-santos vasco-santos force-pushed the chore/restructure-pubsub-tests branch from d42f7f0 to 76745e3 Compare June 13, 2021 19:29
@vasco-santos vasco-santos merged commit 755eb90 into master Jun 13, 2021
@vasco-santos vasco-santos deleted the chore/restructure-pubsub-tests branch June 13, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[testing] fix node 15/16 install due to npm 7 changes
1 participant