fix: use keep-alive tag to reconnect to peers on startup #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to connect to every peer in the peer store when we start a node, only connect to the peers that have been marked with a `keep-alive` tag.
wemeetagain
reviewed
Jun 27, 2022
src/connection-manager/index.ts
Outdated
|
|
||
| for (const peer of await this.components.getPeerStore().all()) { | ||
| const tags = await this.components.getPeerStore().getTags(peer.id) | ||
| const hasKeepAlive = tags.filter(tag => tag.name === 'keep-alive').length > 0 |
There was a problem hiding this comment.
Can you define and export the string as a constant? I think downstream users should tag via exported constants if possible to avoid typos and confusion.
There was a problem hiding this comment.
I've opened this one: libp2p/js-libp2p-interfaces#263
There was a problem hiding this comment.
Mind you, we want to be careful about different modules reusing tag names - otherwise one module could decide a given peer is not important any more and remove the tag, a different module would then be rug-pulled and the bug would be quite hard to track down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to connect to every peer in the peer store when we start a node, only connect to the peers that have been marked with a
keep-alivetag.