Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade aegir to 40.x.x #1900

Merged
merged 3 commits into from
Jul 27, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: specify runner
  • Loading branch information
achingbrain committed Jul 27, 2023
commit 8c3ec177dda7aaf9b307bae761bc6dc1fe6760a3
7 changes: 4 additions & 3 deletions interop/BrowserDockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ FROM mcr.microsoft.com/playwright

COPY --from=node-js-libp2p-head /app/ /app/
WORKDIR /app/interop
RUN npx playwright install
maschad marked this conversation as resolved.
Show resolved Hide resolved
ARG BROWSER=chromium # Options: chromium, firefox, webkit
# Options: chromium, firefox, webkit
ARG BROWSER=chromium
ENV BROWSER=$BROWSER
# disable colored output and CLI animation from test runners
ENV CI true

ENTRYPOINT npm run test:interop:multidim -- --build false --types false -t browser -- --browser $BROWSER
# manually specify runner until https://github.com/hugomrdias/playwright-test/issues/572 is resolved
ENTRYPOINT npm run test:interop:multidim -- --build false --types false -t browser -- --browser $BROWSER --runner mocha
18 changes: 16 additions & 2 deletions interop/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
- [Build another libp2p implementation](#build-another-libp2p-implementation)
- [Running Redis](#running-redis)
- [Start libp2p](#start-libp2p)
- [node.js](#nodejs-1)
- [Browsers](#browsers-1)
- [Start another libp2p implementation](#start-another-libp2p-implementation)
- [License](#license)
- [Contribution](#contribution)
Expand Down Expand Up @@ -67,7 +69,7 @@ $ docker build . -f ./interop/BrowserDockerfile -t js-libp2p-browsers
- When starting the docker container add `-e GOLOG_LOG_LEVEL=debug`
4. Build the version you want to test against
```console
$ cd impl/$IMPL/$VERSION
$ cd multidim-interop/impl/$IMPL/$VERSION
$ make
...
```
Expand All @@ -82,14 +84,26 @@ $ docker run --name redis --rm -p 6379:6379 redis:7-alpine

### Start libp2p

#### node.js

```console
$ docker run -e transport=tcp -e muxer=yamux -e security=noise -e is_dialer=true -e redis_addr=redis:6379 --link redis:redis js-libp2p-node
```

#### Browsers

```console
$ docker run -e transport=webtransport -e muxer=yamux -e security=noise -e is_dialer=true -e redis_addr=redis:6379 --link redis:redis js-libp2p-browsers
```

### Start another libp2p implementation

- Change `go-v0.29` to the implementation you wish to use.
- Ensure one docker run has `is_dialer=false` and the other has `is_dialer=true`
- Ensure the `transport` option is the same for both implementations

```console
$ docker run -e transport=tcp -e muxer=yamux -e security=noise -e is_dialer=false -e redis_addr=redis:6379 --link redis:redis nim-v1.0
$ docker run -e transport=tcp -e muxer=yamux -e security=noise -e is_dialer=false -e redis_addr=redis:6379 --link redis:redis go-v0.29
```

## License
Expand Down
Loading