docs: migration guide -> missing import #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Jan 26, 2024
| Since `libp2p@0.46.10` we have only dialed one address at a time for each peer by setting the default value of the `ConnectionManager`'s `maxParallelDialsPerPeer` option to `1`. As of `libp2p@1.0.0` this option has been removed. |
There was a problem hiding this comment.
this was directly from github UI, doing EOL fix?
SgtPooki
commented
Jan 26, 2024
Comment on lines
405
to
408
| const node = await createLibp2p({ | ||
| peerId, | ||
| peerId | ||
| // ... other options | ||
| }) |
There was a problem hiding this comment.
these fixes come from pasting this code into a new file in an aegir project (helia) and fixing saving causing auto-fix. can revert if desired.
achingbrain
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migration guide (specifically https://github.com/libp2p/js-libp2p/blob/c9ed1c7d62e9af974789eb753d6f8e3c6410df94/doc/migrations/v0.46-v1.0.0.md#keeping-the-same-peerid-after-a-restart) was missing an import for
Key. This may not be the correct import, but appears to be what libp2p/keychain and others are using.related: #2317 once the correct import is added.