-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move to travis #322
Conversation
Windows still needs to be resolved, it's having issues finding the wrtc module. |
@jacobheun did it work on Windows before? |
@daviddias ci has been green for quite a while on master. Did we spin jenkins down already? I was going to look at the specifics of the old windows tests, but it looks like those are gone now. |
I advise that Windows tests are disabled and a new PR to enable them is open right away so that the libp2p team can benefit from Travis running the tests for now. |
@daviddias, yeah @hugomrdias and I were talking about this earlier. With jenkins inactive that's our best path forward. I'm doing some checking today and will do that if I cannot find a different solution in the next few hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed windows from the travis file for now, and will create a subsequent PR for tracking the windows ci inclusion.
you can do this instead matrix:
fast_finish: true
allow_failures:
- os: windows |
@jacobheun see ^^ |
If we're trying to actively fix the windows build it seems wasteful to have windows running at all as it's guaranteed to fail right now. I'd rather see a single, focused branch running windows. If we end up putting off windows until Travis becomes more robust there, then it think it makes sense because then you get "auto discovery" of newly passing windows builds anytime you push a branch or PR. |
* chore: move to travis * chore: move to travis 2 * chore: remove unused test file * chore: remove travis webworker * chore: fix webworker * chore: remove webrtcsupport module * chore: test windows * chore: make windows-build-tools silent * chore: test dllss * chore: test dllss 2 * chore: test dllss 3 * chore: remove before_install stuff * chore: remove windows from CI
No description provided.