Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to travis #322

Merged
merged 13 commits into from
Feb 14, 2019
Merged

chore: move to travis #322

merged 13 commits into from
Feb 14, 2019

Conversation

hugomrdias
Copy link
Member

No description provided.

@ghost ghost assigned hugomrdias Feb 13, 2019
@ghost ghost added the status/in-progress In progress label Feb 13, 2019
@ghost ghost assigned jacobheun Feb 13, 2019
@jacobheun
Copy link
Contributor

Windows still needs to be resolved, it's having issues finding the wrtc module.

@daviddias
Copy link
Member

@jacobheun did it work on Windows before?

@jacobheun
Copy link
Contributor

@daviddias ci has been green for quite a while on master. Did we spin jenkins down already? I was going to look at the specifics of the old windows tests, but it looks like those are gone now.

@daviddias
Copy link
Member

I advise that Windows tests are disabled and a new PR to enable them is open right away so that the libp2p team can benefit from Travis running the tests for now.

@jacobheun
Copy link
Contributor

@daviddias, yeah @hugomrdias and I were talking about this earlier. With jenkins inactive that's our best path forward. I'm doing some checking today and will do that if I cannot find a different solution in the next few hours.

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed windows from the travis file for now, and will create a subsequent PR for tracking the windows ci inclusion.

@jacobheun jacobheun merged commit 59fe973 into master Feb 14, 2019
@ghost ghost removed the status/in-progress In progress label Feb 14, 2019
@hugomrdias
Copy link
Member Author

you can do this instead

matrix:
  fast_finish: true
  allow_failures:
    - os: windows

@jacobheun jacobheun deleted the chore/move-travis branch February 14, 2019 17:08
@daviddias
Copy link
Member

@jacobheun see ^^

@jacobheun
Copy link
Contributor

jacobheun commented Feb 14, 2019

If we're trying to actively fix the windows build it seems wasteful to have windows running at all as it's guaranteed to fail right now. I'd rather see a single, focused branch running windows.

If we end up putting off windows until Travis becomes more robust there, then it think it makes sense because then you get "auto discovery" of newly passing windows builds anytime you push a branch or PR.

Isan-Rivkin pushed a commit to Isan-Rivkin/js-libp2p that referenced this pull request Feb 20, 2019
* chore: move to travis

* chore: move to travis 2

* chore: remove unused test file

* chore: remove travis webworker

* chore: fix webworker

* chore: remove webrtcsupport module

* chore: test windows

* chore: make windows-build-tools silent

* chore: test dllss

* chore: test dllss 2

* chore: test dllss 3

* chore: remove before_install stuff

* chore: remove windows from CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants