fix: await peer discovery start in libp2p start #600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_setupPeerDiscovery
returns aPromise
that resolves after all discovery modules are started.Because we are not awaiting
_setupPeerDiscovery
in the call tolibp2p.start
, we run into a situation where underlying discovery modules have not been started until after the top-levelstart
has resolved.This can lead to unintended behavior where discovery modules may be started after the libp2p instance has been stopped.
eg:
This is a minimal fix to await
_setupPeerDiscovery
in the process of starting a libp2p node. The new behavior now awaits all peer discovery modules beingstart
ed before resolving that the lib2p node has started.