Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not dial all known peers in parallel on startup #698

Merged
merged 9 commits into from
Jul 14, 2020
Merged

fix: not dial all known peers in parallel on startup #698

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
695f77c
fix: not dial all known peers on startup
vasco-santos Jul 9, 2020
3fcc2d6
feat: connection manager should proactively connect to peers from pee…
vasco-santos Jul 9, 2020
4afb801
chore: increase bundle size
vasco-santos Jul 9, 2020
6ac3328
fix: do connMgr proactive dial on an interval
vasco-santos Jul 14, 2020
9156e29
chore: address review
vasco-santos Jul 14, 2020
2985a5f
chore: use retimer reschedule
vasco-santos Jul 14, 2020
4ea8838
chore: address review
vasco-santos Jul 14, 2020
c92d2ea
fix: use minConnections in default config
vasco-santos Jul 14, 2020
43a52a6
chore: minPeers to minConnections everywhere
vasco-santos Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: use retimer reschedule
  • Loading branch information
@vasco-santos
vasco-santos committed Jul 14, 2020
commit 2985a5f7db34e727b1cf5621a093b9bed7c5694a
13 changes: 10 additions & 3 deletions src/connection-manager/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,17 @@ class ConnectionManager extends EventEmitter {
async _autoDial () {
const minConnections = this._options.minConnections

const recursiveTimeoutTrigger = () => {
if (this._autoDialTimeout) {
this._autoDialTimeout.reschedule(this._options.autoDialInterval)
} else {
this._autoDialTimeout = retimer(this._autoDial, this._options.autoDialInterval)
}
}

// Already has enough connections
if (this.size >= minConnections) {
this._autoDialTimeout = retimer(this._autoDial, this._options.autoDialInterval)

recursiveTimeoutTrigger()
return
jacobheun marked this conversation as resolved.
Show resolved Hide resolved
}

Expand Down Expand Up @@ -325,7 +332,7 @@ class ConnectionManager extends EventEmitter {
}
}

this._autoDialTimeout = retimer(this._autoDial, this._options.autoDialInterval)
recursiveTimeoutTrigger()
}

/**
Expand Down