feat: gossipsub 1.1 #733
Merged
feat: gossipsub 1.1 #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feature/gossipsub-1.1
branch
2 times, most recently
from
cebc2e6
to
5ff64cb
Compare
vasco-santos
force-pushed
the
feature/gossipsub-1.1
branch
2 times, most recently
from
c3dc02b
to
3466ef4
Compare
2 tasks
vasco-santos
force-pushed
the
feature/gossipsub-1.1
branch
from
8686e9a
to
d722c4d
Compare
BREAKING CHANGE: pubsub implementation is now directly exposed and its API was updated according to the new pubsub interface in js-libp2p-interfaces repo
jacobheun
force-pushed
the
feature/gossipsub-1.1
branch
from
d722c4d
to
0db9a31
Compare
vasco-santos
commented
Aug 25, 2020
| libp2p.pubsub.topicValidators.set(topic, validateMessage) | ||
| ``` | ||
|
|
||
| ## pubsub.topicValidators.delete |
There was a problem hiding this comment.
Needs to be added to the toc
jacobheun
reviewed
Aug 25, 2020
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
vasco-santos
force-pushed
the
feature/gossipsub-1.1
branch
from
7bb739d
to
8ea18af
Compare
|
merging this and will do an RC, we can update deps prior to release |
jacobheun
added a commit
that referenced
this pull request
Aug 27, 2020
* feat: gossipsub 1.1 BREAKING CHANGE: pubsub implementation is now directly exposed and its API was updated according to the new pubsub interface in js-libp2p-interfaces repo * chore: use gossipsub branch with src added * fix: add pubsub handlers adapter * chore: fix deps * chore: update pubsub docs and examples * chore: apply suggestions from code review Co-authored-by: Jacob Heun <jacobheun@gmail.com> * chore: use new floodsub * chore: change validator doc set Co-authored-by: Jacob Heun <jacobheun@gmail.com> * chore: add new gossipsub src Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR main purpose is to update gossipsub 1.1
With this initiative, we included a refactor of the pubsub abstraction API included in
js-libp2pmodule per libp2p/js-libp2p-pubsub#68 , as well as a pubsub base implementation (libp2p/js-libp2p-pubsub) full refactor that also included moving it into libp2p interfaces per libp2p/js-libp2p-interfaces#53With the above changes,
libp2p-floodsubwas also updated accordingly.Needs:
feat: interface pubsub js-libp2p-interfaces#60 (with https://github.com/libp2p/js-libp2p-pubsub/tree/v0.6.x)
libp2p/js-libp2p-floodsub#108
ChainSafe/js-libp2p-gossipsub#82
Interop circular dependency chore: gossipsub1.1 interop#43