public key derivation from private key stored in go-ipfs config file #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| } | ||
|
|
||
| if(type == 'Private'){ |
|
@nginnever Gave some input, thank you for making this :) Also, will you change the tests to WebPack and Mocha on this PR? |
| @@ -6,7 +6,10 @@ peer-id JavaScript implementation | |||
|
|
|||
| # Description | |||
|
|
|||
| A IPFS Peer Id is based on a sha256 has of the peer public key, using [multihash](https://github.com/jbenet/multihash) | |||
| A IPFS Peer Id is based on a sha256 hash of the peer public key, using [multihash](https://github.com/jbenet/multihash) | |||
There was a problem hiding this comment.
thank you for catching this :)
|
Looks pretty good! Just a few nitpicks and will merge and release :D Thank you @nginnever, you are awesome! |
|
think i hit everything, let me know if i missed something or if you want me to squash the commit chain i just made lol |
daviddias
added a commit
that referenced
this pull request
Feb 14, 2016
public key derivation from private key stored in go-ipfs config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output currently does not pass the assertion that the base64 encoded protobuf of the public key derived from the go-clients config actually matches the go clients public key hard coded into the test.
The issue may be with the way forge is creating the DER buffer, note that it seems to buffer a buffer at one point.
This does seem capable of unmarshalling the base64 encoded protobuf private key stored in the go config file when it grabs the modulus and exponent values before creating the public key from them.
Edit: Output now matches