Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor gossipsub: make modules private #3494

Closed
4 tasks
StemCll opened this issue Feb 22, 2023 · 3 comments · Fixed by #3777
Closed
4 tasks

refactor gossipsub: make modules private #3494

StemCll opened this issue Feb 22, 2023 · 3 comments · Fixed by #3777

Comments

@StemCll
Copy link
Contributor

StemCll commented Feb 22, 2023 •
edited
Loading

Description

As described in this comment:

  • protocol - PR
  • metrics - PR
  • subscription_filter - PR
  • time_cache - PR

Are you planning to do it yourself in a pull request?

Yes
@StemCll StemCll changed the title gossipsub: make protocol module private refactor gossipsub: make modules private Feb 22, 2023
@thomaseizinger thomaseizinger mentioned this issue Mar 13, 2023
Closed
@tcoratger tcoratger mentioned this issue Apr 5, 2023
Merged
3 tasks
@tcoratger
Copy link
Contributor

@thomaseizinger Is there an associated PR closed? Is it work in progress @StemCll ? After the work on kad modules in #3738, this seems straightforward to go through gossipsub ones, what do you think?

@thomaseizinger
Copy link
Contributor

@thomaseizinger Is there an associated PR closed? Is it work in progress @StemCll ? After the work on kad modules in #3738, this seems straightforward to go through gossipsub ones, what do you think?

There are 4 PRs linked in the description (all labeled PR) but I think @StemCll currently doesn't have the capacity to work on them. Feel free to take over! I think a single PR would be best.

@tcoratger
Copy link
Contributor

@thomaseizinger Understood, will start working on that in the upcoming days.

mergify bot pushed a commit that referenced this issue Apr 11, 2023
@tcoratger
feat(kad): make implementation modules private
4cac590 
Similar to #3494, make implementation modules private for Kademlia (`kad`).

Resolves #3608.

Pull-Request: #3738.
@tcoratger tcoratger mentioned this issue Apr 12, 2023
Merged
2 tasks
@mergify mergify bot closed this as completed in #3777 Apr 23, 2023
mergify bot pushed a commit that referenced this issue Apr 23, 2023
@tcoratger
feat(gossipsub): make gossipsub modules private
270d204 
Resolves #3494.

Pull-Request: #3777.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gossipsub): make gossipsub modules private tcoratger/rust-libp2p
3 participants
@thomaseizinger @StemCll @tcoratger